fix(doctor): allow vendor slugs for named custom providers - #42411
Merged
Merged
Conversation
…dicate Collapse the bare-"custom" allowlist entry and the custom:<name> guard into a single provider_accepts_vendor_slug predicate so the slug-warning suppression reads as one rule instead of two scattered conditions. No behavior change.
Contributor
🔎 Lint report:
|
alt-glitch
added
type/bug
Contributor
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes doctorno longer tells users on a named custom provider to drop a vendor prefix their backend requires. Named custom providers (custom:hpc-ai) can front aggregator-style OpenAI-compatible services, soprovider: custom:hpc-ai+default: deepseek/deepseek-v4-flashis valid — but doctor's allowlist only had bare"custom", while a named custom provider resolves to the fullcustom:hpc-aistring and never matched, so the warning fired.Salvage of #42364 by @helix4u onto current
main, plus a small follow-up that folds the two scatteredcustomconditions into one predicate.Changes
hermes_cli/doctor.py: suppress the vendor/model slug warning for barecustomand namedcustom:<name>providers via a singleprovider_accepts_vendor_slugpredicate.hermes_cli/providers.py: classifycustom:<name>as an aggregator so model-switch and doctor agree.tests/: regression coverage forcustom:hpc-ai+deepseek/deepseek-v4-flashand the aggregator classification.Validation
E2E via the real
hermes doctoragainst an isolated HERMES_HOME:custom:hpc-ai+deepseek/deepseek-v4-flashcustom+ vendor sluganthropic+anthropic/claude-sonnet-4(non-aggregator)Targeted tests:
tests/hermes_cli/test_doctor.py+test_model_switch_custom_providers.py— 87/87 pass.Reported from Discord support. Closes #42364 (cherry-picked with @helix4u's authorship preserved).
Infographic