Skip to content

fix(cli): treat named custom providers as aggregators - #26591

Closed
googlerest wants to merge 2 commits into
NousResearch:mainfrom
googlerest:codex/fix-custom-provider-aggregator
Closed

googlerest wants to merge 2 commits into
NousResearch:mainfrom
googlerest:codex/fix-custom-provider-aggregator

Conversation

@googlerest

@googlerest googlerest commented May 15, 2026

Copy link
Copy Markdown

Summary

  • Treat named custom providers like custom:zenmux as aggregators for model alias resolution.
  • Suppress the false-positive doctor vendor-prefix warning for named custom providers.
  • Add regressions for is_aggregator("custom:zenmux") and hermes doctor with custom:zenmux + z-ai/glm-5.1.

Fixes #26578.

Verification

  • scripts/run_tests.sh tests/hermes_cli/test_model_switch_custom_providers.py::test_named_custom_provider_is_aggregator tests/hermes_cli/test_doctor.py::test_run_doctor_accepts_vendor_slug_for_named_custom_provider
  • scripts/run_tests.sh tests/hermes_cli/test_model_switch_custom_providers.py tests/hermes_cli/test_doctor.py
  • git diff --check
  • python -m py_compile hermes_cli/providers.py hermes_cli/doctor.py

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/cli CLI entry point, hermes_cli/, setup wizard duplicate This issue or pull request already exists labels May 15, 2026
@alt-glitch

Copy link
Copy Markdown
Contributor

Duplicate of #26594 — both PRs fix the same issue (#26578: custom:<name> providers not recognized as aggregators). Both make identical functional changes to providers.py and doctor.py. #26594 has more thorough docstrings and test coverage.

@googlerest

Copy link
Copy Markdown
Author

Duplicate of #26594 which covers the same fix. Closing in favor of that PR.

@googlerest googlerest closed this Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard duplicate This issue or pull request already exists P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

custom:<name> providers not recognized as aggregators (custom:zenmux)

2 participants