Skip to content

fix: add privileged post-review kanban reconciliation - #39795

Closed
2seok2 wants to merge 1 commit into
NousResearch:mainfrom
2seok2:wt/kanban-privileged-reconcile
Closed

fix: add privileged post-review kanban reconciliation#39795
2seok2 wants to merge 1 commit into
NousResearch:mainfrom
2seok2:wt/kanban-privileged-reconcile

Conversation

@2seok2

@2seok2 2seok2 commented Jun 5, 2026

Copy link
Copy Markdown

Summary

  • Add an evidence-gated reconcile_post_review_closure DB helper for approved+merged post-review lanes.
  • Add hermes kanban reconcile-post-review as a privileged unscoped runner/orchestrator CLI path; dispatcher-scoped workers cannot use it unless trusted runner code explicitly opts in.
  • Document the closure protocol in the bundled kanban-worker skill.

Validation

  • python -m pytest tests/hermes_cli/test_kanban_db.py tests/tools/test_kanban_tools.py -q -o 'addopts=' (298 passed, 1 warning)
  • python -m compileall -q hermes_cli/kanban.py hermes_cli/kanban_db.py
  • Read-only lineage check for web-archive tasks t_38969b18 / t_357a83e4 / t_be51753e confirmed original/review/closure done, approved metadata, and PR fix(security): prevent shell injection in sudo password piping #65 merged summary evidence.

Safety

  • Keeps existing worker cross-task mutation guard intact.
  • New reconciliation path requires explicit review_approved=true and pr_merged=true evidence plus completed reviewer metadata approved=true for the original task.

@alt-glitch alt-glitch added type/feature New feature or request P3 Low — cosmetic, nice to have comp/cli CLI entry point, hermes_cli/, setup wizard labels Jun 5, 2026
@2seok2

2seok2 commented Jun 5, 2026

Copy link
Copy Markdown
Author

Superseded by local Hermes ops overlay patch per user direction: do not touch official hermes-agent files for this incident. Closing this upstream PR path instead of pursuing maintainer-gated merge.

@2seok2 2seok2 closed this Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants