fix: add privileged post-review kanban reconciliation - #39795
Closed
2seok2 wants to merge 1 commit into
Closed
Conversation
Author
|
Superseded by local Hermes ops overlay patch per user direction: do not touch official hermes-agent files for this incident. Closing this upstream PR path instead of pursuing maintainer-gated merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reconcile_post_review_closureDB helper for approved+merged post-review lanes.hermes kanban reconcile-post-reviewas a privileged unscoped runner/orchestrator CLI path; dispatcher-scoped workers cannot use it unless trusted runner code explicitly opts in.Validation
python -m pytest tests/hermes_cli/test_kanban_db.py tests/tools/test_kanban_tools.py -q -o 'addopts='(298 passed, 1 warning)python -m compileall -q hermes_cli/kanban.py hermes_cli/kanban_db.pySafety
review_approved=trueandpr_merged=trueevidence plus completed reviewer metadataapproved=truefor the original task.