Skip to content

fix(nix): stage consolidated lockfile hash - #39589

Closed
rylena wants to merge 1 commit into
NousResearch:mainfrom
rylena:fix/issue-39455-nix-lockfile-fix-lib
Closed

fix(nix): stage consolidated lockfile hash#39589
rylena wants to merge 1 commit into
NousResearch:mainfrom
rylena:fix/issue-39455-nix-lockfile-fix-lib

Conversation

@rylena

@rylena rylena commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Update nix-lockfile-fix.yml to whitelist and stage the consolidated nix/lib.nix hash file.
  • Apply the same nix/lib.nix guard to the manual PR fix path before committing.
  • Refresh workflow comments so the safety invariant matches the current single-hash file layout.

Verification

  • python - <<'PY' ... yaml.safe_load(...) to parse .github/workflows/nix-lockfile-fix.yml and assert stale nix/tui.nix / nix/web.nix references are gone
  • Shell guard checks confirming nix/lib.nix is allowed and old/package paths are rejected
  • git diff --check -- .github/workflows/nix-lockfile-fix.yml
  • Static added-line security scan
  • Independent delegated code review: passed

Closes #39455

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists area/nix Nix flake, NixOS module, container packaging labels Jun 9, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Duplicate of #39459 (also #39475, #39814, #41004) — all fix #39455 by staging consolidated nix/lib.nix instead of the removed per-package hash files. Consolidating on the earliest open PR.

@rylena

rylena commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

Closing this as a duplicate of #39459 for the same #39455 fix, per the maintainer triage note, so effort stays concentrated on the earlier open PR. I also verified #39459 is still open.

@rylena rylena closed this Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/nix Nix flake, NixOS module, container packaging P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nix-lockfile-fix.yml can never commit its hash update — stages nix/tui.nix + nix/web.nix, but fix-lockfiles writes nix/lib.nix

2 participants