Skip to content

fix(nix): stage consolidated lockfile hash - #39475

Closed
AndyBoWu wants to merge 1 commit into
NousResearch:mainfrom
AndyBoWu:fix/nix-lockfile-lib-hash-workflow
Closed

fix(nix): stage consolidated lockfile hash#39475
AndyBoWu wants to merge 1 commit into
NousResearch:mainfrom
AndyBoWu:fix/nix-lockfile-lib-hash-workflow

Conversation

@AndyBoWu

@AndyBoWu AndyBoWu commented Jun 5, 2026

Copy link
Copy Markdown

Summary

  • update nix-lockfile-fix workflow to allow and stage nix/lib.nix, where the consolidated npmDepsHash now lives
  • stop staging the removed/pre-refactor nix/tui.nix and nix/web.nix hash files
  • add regression coverage for the workflow guard and staging targets

Fixes #39455

Test Plan

  • python -m pytest tests/test_nix_lockfile_fix_workflow.py -q -o 'addopts='
  • python YAML parse check for .github/workflows/nix-lockfile-fix.yml

@alt-glitch alt-glitch added type/bug Something isn't working P1 High — major feature broken, no workaround area/nix Nix flake, NixOS module, container packaging labels Jun 5, 2026

@tonydwb tonydwb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary

Verdict: Approved

Nix lockfile workflow fix: consolidates from two separate staged files (nix/tui.nix + nix/web.nix) to one (nix/lib.nix). Also tightens the guard regex to only allow nix/lib.nix, preventing the workflow from accidentally committing other files.

Looks Good

  • Regex fix (-Ev '^nix/lib.nix$') correctly replaces the overly broad (tui|web) allowlist.
  • Test coverage added: validates both the staged files and the allowlist regex.

No concerns

  • Small, well-scoped infrastructure fix with adequate tests.

Reviewed by Hermes Agent

@teknium1

Copy link
Copy Markdown
Contributor

Automated hermes-sweeper review found this is already handled on main.

Evidence:

Thanks for the focused fix and regression coverage; the same functional change landed through the later mainline Nix workflow work.

@teknium1 teknium1 closed this Jun 21, 2026
@teknium1 teknium1 added the sweeper:implemented-on-main Sweeper: behavior already present on current main label Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/nix Nix flake, NixOS module, container packaging P1 High — major feature broken, no workaround sweeper:implemented-on-main Sweeper: behavior already present on current main type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nix-lockfile-fix.yml can never commit its hash update — stages nix/tui.nix + nix/web.nix, but fix-lockfiles writes nix/lib.nix

4 participants