fix(nix): stage consolidated lockfile hash - #39475
Closed
AndyBoWu wants to merge 1 commit into
Closed
Conversation
tonydwb
approved these changes
Jun 5, 2026
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
Nix lockfile workflow fix: consolidates from two separate staged files (nix/tui.nix + nix/web.nix) to one (nix/lib.nix). Also tightens the guard regex to only allow nix/lib.nix, preventing the workflow from accidentally committing other files.
Looks Good
- Regex fix (-Ev '^nix/lib.nix$') correctly replaces the overly broad (tui|web) allowlist.
- Test coverage added: validates both the staged files and the allowlist regex.
No concerns
- Small, well-scoped infrastructure fix with adequate tests.
Reviewed by Hermes Agent
Contributor
|
Automated hermes-sweeper review found this is already handled on main. Evidence:
Thanks for the focused fix and regression coverage; the same functional change landed through the later mainline Nix workflow work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #39455
Test Plan