chore(deps): bump aiohttp to clear security advisories - #39467
chore(deps): bump aiohttp to clear security advisories#39467EvilHumphrey wants to merge 3 commits into
Conversation
|
Both red checks here look transient/unrelated to this change — not the aiohttp bump:
Could a maintainer re-run the two failed jobs when convenient? Both should go green on a retry. Happy to rebase onto fresh |
|
Follow-up commit ( Hermes' lazy deps use exact pins and can install/downgrade a package on their own, so the manifest bump alone wasn't enough: OSV shows |
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
Straightforward dependency security bump: aiohttp 3.13.3 → 3.14.0, clearing multiple CVEs (CVE-2026-34513/34518/34519/34520/34525 and others). All extras (messaging, slack, homeassistant, sms) updated consistently.
Looks Good
- Version bump is consistent across pyproject.toml, lazy_deps.py, and uv.lock.
- The comment in lazy_deps.py accurately reflects what the new version clears.
- No API changes expected from a patch/minor upgrade within aiohttp 3.x.
No concerns
- Standard security maintenance.
Reviewed by Hermes Agent
…0260605 # Conflicts: # pyproject.toml # uv.lock
|
Rebased onto current Re-framing since Small and self-contained, |
|
Closing as superseded — aiohttp 3.14.0 is the canonical bump in #42334 (already approved), which also covers the full CVE set including 34520 (9.1). Thanks for the contribution! |
What
Bump aiohttp
3.13.3→3.14.0to clear all outstanding security advisories OSV flagged against the locked version.Touches the exact pin in
pyproject.toml(4 extras) and re-resolvesuv.lockscoped to aiohttp only. No other package moves.Why — headline: a 9.1 Critical
The locked aiohttp
3.13.3carries 12 known advisories, led by a CVSS 9.1 Critical:Most of these are fixed in
3.13.4, but two require3.14.0, so3.14.0is the minimum version that clears the entire set:All advisories cleared (aiohttp 3.13.3 → 3.14.0)
\rin reason phraseOSV verification:
aiohttp 3.13.3→ 12 advisories;aiohttp 3.14.0→ 0 advisories.Changes
pyproject.toml— bump the exact pinaiohttp==3.13.3→aiohttp==3.14.0in the 4 extras that declare it:messaging,slack,homeassistant,sms. (The pin had to move becauseuv lock --upgrade-packagecannot cross an==constraint. Kept exact-pin style to match the file's convention; theall/termux-allaggregates inherit the new pin viahomeassistant/sms.)uv.lock— re-resolved withuv lock --upgrade-package aiohttp. The only package version that changed is aiohttp (3.13.3 → 3.14.0); the rest of the diff is aiohttp's own wheel/hash set plus the root project'srequires-distmetadata recording the new specifier.Validation
uv lock --check→ lockfile is in sync (pre-validates theuv-lockfile-check.ymlCI gate).uv-lockfile-check) validates runtime compatibility of the 3.13.3 → 3.14.0 minor bump.uv sync/ install / test execution was run locally — this is a resolution-only lockfile change.