chore(deps): clear npm audit advisories in website + whatsapp-bridge lockfiles - #39450
chore(deps): clear npm audit advisories in website + whatsapp-bridge lockfiles#39450EvilHumphrey wants to merge 1 commit into
Conversation
… audit advisories
|
The failing The scan also covers That Critical is fixed by #39467 (bumps Suggested order:
The npm audit changes in this PR are unrelated to the |
|
Good, well-scoped security work — but it needs a refresh before merge, and there's a coordination point with the Baileys PRs. Verdict: Comment (not blocking on quality, but it no longer achieves "0 advisories" and is stale). Verified the bumps are real and correctly scopedConfirmed in the diff: undici 7.23.0→7.27.1, protobufjs 7.5.6→7.6.2, qs→6.15.2, ws→8.21.0, path-to-regexp 0.1.12→0.1.13 — all patch/minor security bumps. Both files are standalone lockfiles ( But
|
|
Thanks for the thorough re-review! I agree on all points and good catch on the new advisory Rebase onto current main and regenerate both lockfiles so the diff reflects today's advisory set. (The red osv-scan here is the separate aiohttp-in-uv.lock critical tracked in #42334, not these lockfiles — it'll clear when that lands.) |
|
Closing this out — re-checked against current website: whatsapp-bridge: ceding this lockfile to #43840 (Baileys rc13 → clears the GHSA-qvv5 critical) + #44358 (same transitive bumps as here, protobufjs slightly newer at 7.6.3), which together take it to 0 — rather than force-pushing a duplicate. (#44980 looks like another copy of #44358, FYI.) For the record, the red |
Refreshes two standalone lockfiles to clear all current
npm auditadvisories on those surfaces. Lockfile-only — nopackage.jsonchanges, no major bumps.website/ — 9 → 0 (3 high, 6 moderate)
scripts/whatsapp-bridge/ — 4 → 0 (moderate)
Verified
npm audit --package-lock-only→ 0 on both. These locks are standalone (not Nix-built), so nonix/lib.nixchange is required. Supersedes the website/bridge portion of #39304 (which bundled these with the Nix-coupled root lock and became conflicted); the remaining root react-router advisory is Nix-coupled and tracked separately.