fix(tools): add raise_for_status for MiniMax t2a_v2 TTS path - #39057
Merged
Conversation
The MiniMax t2a_v2 code path calls response.json() without first checking the HTTP status code. If the API returns HTTP 4xx/5xx with non-JSON content (e.g. HTML error page), response.json() raises an opaque JSONDecodeError instead of a clear HTTPError. The non-t2a_v2 path already has response.raise_for_status() at line 1299. Add the same check before response.json() in the t2a_v2 path for consistent error handling.
Contributor
🔎 Lint report:
|
alt-glitch
added
type/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The MiniMax
t2a_v2TTS path now surfaces a clearHTTPErroron a 4xx/5xx response instead of an opaqueJSONDecodeError.Previously, on an HTTP error with a non-JSON body,
response.json()raised a confusingJSONDecodeError. The siblingtext_to_speechpath already guarded withraise_for_status(); this bringst2a_v2to parity.Changes
tools/tts_tool.py: addresponse.raise_for_status()beforeresponse.json()in thet2a_v2branch.Validation
JSONDecodeErrorHTTPErrorpy_compileOKSalvage of #38142 by @annguyenNous, cherry-picked onto current main with authorship preserved.
Infographic