fix(tools): add raise_for_status for MiniMax t2a_v2 TTS path - #38142
Closed
annguyenNous wants to merge 1 commit into
Closed
fix(tools): add raise_for_status for MiniMax t2a_v2 TTS path#38142annguyenNous wants to merge 1 commit into
annguyenNous wants to merge 1 commit into
Conversation
The MiniMax t2a_v2 code path calls response.json() without first checking the HTTP status code. If the API returns HTTP 4xx/5xx with non-JSON content (e.g. HTML error page), response.json() raises an opaque JSONDecodeError instead of a clear HTTPError. The non-t2a_v2 path already has response.raise_for_status() at line 1299. Add the same check before response.json() in the t2a_v2 path for consistent error handling.
alt-glitch
added
type/bug
Contributor
|
Merged via PR #39057 — your commit was cherry-picked onto current main with your authorship preserved in git log. Thanks @annguyenNous! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
tools/tts_tool.py, the MiniMax t2a_v2 TTS code path callsresponse.json()without first checking the HTTP status code. If the API returns HTTP 4xx/5xx with non-JSON content,response.json()raises an opaqueJSONDecodeErrorinstead of a clearHTTPError.The non-t2a_v2 path already has
response.raise_for_status()at line 1299.Fix
Add
response.raise_for_status()beforeresponse.json()in the t2a_v2 path.Files Changed
tools/tts_tool.py— 1 line added