Skip to content

fix(skills): ignore nested markdown assets in skill_view - #35889

Closed
MarsDoge wants to merge 1 commit into
NousResearch:mainfrom
MarsDoge:fix/skill-view-ignore-nested-assets
Closed

fix(skills): ignore nested markdown assets in skill_view#35889
MarsDoge wants to merge 1 commit into
NousResearch:mainfrom
MarsDoge:fix/skill-view-ignore-nested-assets

Conversation

@MarsDoge

Copy link
Copy Markdown

Summary

  • Fix skill_view("<name>") so nested markdown references/templates/assets inside another skill package are not treated as legacy standalone skills.
  • Preserve collision detection for real same-name skills across local/external skill directories.
  • Add a regression test covering the bundled-style templates/notion.md asset collision scenario.

Test Plan

  • venv/bin/python -m pytest tests/tools/test_skills_tool.py::TestSkillViewCollisionDetection -q
  • venv/bin/python -m pytest tests/tools/test_skills_tool.py tests/test_plugin_skills.py -q
  • Manual: skill_view("notion") now resolves productivity/notion/SKILL.md successfully.

Closes #35743

@MarsDoge

Copy link
Copy Markdown
Author

Closing as duplicate of #35768, which already fixes #35743 and has passing checks. Thanks!

@MarsDoge MarsDoge closed this May 31, 2026
@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists tool/skills Skills system (list, view, manage) labels May 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2 Medium — degraded but workaround exists tool/skills Skills system (list, view, manage) type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: skill_view falsely reports collision when another skill has an asset file with the same name

2 participants