Skip to content

fix(skills): ignore nested assets in skill lookup - #35768

Closed
BROCCOLO1D wants to merge 2 commits into
NousResearch:mainfrom
BROCCOLO1D:fix/35743-skill-view-assets
Closed

fix(skills): ignore nested assets in skill lookup#35768
BROCCOLO1D wants to merge 2 commits into
NousResearch:mainfrom
BROCCOLO1D:fix/35743-skill-view-assets

Conversation

@BROCCOLO1D

Copy link
Copy Markdown
Contributor

Summary

Why

  • skill_view notion could report an ambiguous collision when another skill contained templates/notion.md or references/.../notion.md.
  • Those Markdown files are assets of their parent skill, not loadable skills, so they should not participate in bare-name collision detection.

Changes

  • tools/skills_tool.py: skips Strategy 3 legacy <name>.md hits when an ancestor directory already contains SKILL.md.
  • tests/test_plugin_skills.py: adds regression coverage for nested asset collisions and preserves top-level legacy flat .md skill lookup.

Validation

  • python -m pytest tests/test_plugin_skills.py -q -o 'addopts='
  • python -m ruff check tools/skills_tool.py tests/test_plugin_skills.py
  • git diff --check

Scope

  • In scope: bare-name skill_view candidate discovery for nested Markdown asset files.
  • Out of scope: changing explicit categorized skill/file lookup semantics or broader skill index behavior.

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists tool/skills Skills system (list, view, manage) labels May 31, 2026
@BROCCOLO1D

Copy link
Copy Markdown
Contributor Author

Closing this as stale: there has been no activity or maintainer follow-up for over a week, and I don't want to leave inactive work open. Happy to reopen/rework if this becomes useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2 Medium — degraded but workaround exists tool/skills Skills system (list, view, manage) type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: skill_view falsely reports collision when another skill has an asset file with the same name

2 participants