fix(tui): include child transcripts in resume picker - #35780
Closed
mzkarami wants to merge 1 commit into
Closed
Conversation
Collaborator
Contributor
Author
|
duplicate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes the TUI historical session picker and auto-resume path include message-bearing child sessions, while continuing to filter empty shell/internal tool-only rows.
This addresses the case where real transcripts are stored as child sessions but the TUI resume picker surfaces parent/compression shell rows instead, making valid sessions hard to resume from the TUI.
Related Issue
Refs #35542
Type of Change
Changes Made
tui_gateway/server.pyinclude_children=Truewhen listing historical sessions forsession.list.include_children=Truewhen resolvingsession.most_recent.toolrows.tests/test_tui_gateway_server.pysession.listincludes message-bearing child sessions.session.most_recentprefers the newest resumable child transcript over empty shell rows.tests/gateway/test_session_list_allowed_sources.pyHow to Test
git diff --checkpython -m pytest tests/test_tui_gateway_server.py -qpython -m pytest tests/gateway/test_session_list_allowed_sources.py -qHERMES_TEST_WORKERS=8 python scripts/run_tests_parallel.py --slice 5/6Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — N/A: no docs surface changedcli-config.yaml.exampleif I added/changed config keys — N/A: no config keys changedCONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — N/A: no architecture/workflow changedFor New Skills
N/A — this PR does not add a skill.
Screenshots / Logs
Focused tests:
CI-equivalent shard: