fix(tui): show child transcript sessions in resume - #35544
Closed
BROCCOLO1D wants to merge 1 commit into
Closed
Conversation
tonydwb
approved these changes
May 30, 2026
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved ✅
Review Findings
This PR fixes the TUI session resume path to include child transcript sessions and filter out empty shell rows. Previously, session.list and session.most_recent didn't request child rows, making transcript-bearing children invisible while empty parent shells were shown.
✅ Looks Good
- Root cause:
list_sessions_rich()called withoutinclude_children=True— child rows with actual messages were hidden. - Fix: Passes
include_children=True,project_compression_tips=False, andorder_by_last_active=Trueto get raw child rows in last-active order. - Empty row filter: Requires
message_count > 0after source filtering, so zero-message parent shells don't block resumable child sessions. - Test coverage: 3 test files updated with specific assertions for the new query parameters and filtering behavior.
- Minimal diff: 59 additions, 12 deletions.
No Issues Found
Reviewed by Hermes Agent
This was referenced May 31, 2026
23 tasks
Contributor
Author
|
Closing this as stale: there has been no activity or maintainer follow-up for over a week, and I don't want to leave inactive work open. Happy to reopen/rework if this becomes useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toolrows so empty compression/coordination parents do not hide resumable sessions.Closes #35542
Why
session.listandsession.most_recentqueriedlist_sessions_rich(...)withoutinclude_children=True, so transcript-bearing child rows could be hidden while empty parent shell rows were surfaced.state.db.Changes
tui_gateway/server.py: request child rows, raw last-active ordering, and no compression-tip projection for TUI resume/list queries; require positivemessage_countafter source filtering.tests/gateway/test_session_list_allowed_sources.py: cover the child transcript / empty shell filtering behavior and query kwargs.tests/test_tui_gateway_server.py: cover the same behavior forsession.most_recent.Validation
python -m pytest tests/test_tui_gateway_server.py tests/gateway/test_session_list_allowed_sources.py -q -o 'addopts='(191 passed)python -m ruff check tui_gateway/server.py tests/test_tui_gateway_server.py tests/gateway/test_session_list_allowed_sources.pygit diff --checkScope
/sessionsvs/resumeproduct semantics or gateway resume scoping changes.