fix(gateway): scope progress thread fallback to Slack only (salvage #3414) - #3488
Merged
Conversation
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
…ousResearch#3414) (NousResearch#3488) * test(gateway): map fixture adapter by platform in progress threading tests * fix(gateway): scope progress thread fallback to Slack only --------- Co-authored-by: EmpireOperating <258363005+EmpireOperating@users.noreply.github.com>
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…ousResearch#3414) (NousResearch#3488) * test(gateway): map fixture adapter by platform in progress threading tests * fix(gateway): scope progress thread fallback to Slack only --------- Co-authored-by: EmpireOperating <258363005+EmpireOperating@users.noreply.github.com>
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
…ousResearch#3414) (NousResearch#3488) * test(gateway): map fixture adapter by platform in progress threading tests * fix(gateway): scope progress thread fallback to Slack only --------- Co-authored-by: EmpireOperating <258363005+EmpireOperating@users.noreply.github.com>
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
…ousResearch#3414) (NousResearch#3488) * test(gateway): map fixture adapter by platform in progress threading tests * fix(gateway): scope progress thread fallback to Slack only --------- Co-authored-by: EmpireOperating <258363005+EmpireOperating@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #3414 by @EmpireOperating. Cherry-picked clean, no modifications needed.
Problem: The
event_message_idfallback for progress thread metadata was applied cross-platform. In Telegram DMs, this passes a normal message ID asmessage_thread_id(a forum-topic-only field), causingBadRequest: Message thread not founderrors that silently kill progress messages.Fix: Scope the fallback to Slack only — Slack DMs need it so progress messages land in the same thread as the final reply. Other platforms use
source.thread_iddirectly, which isNonewhen there's no thread/forum (correct behavior).3 tests pass: original topic threading + Telegram DM (no fallback) + Slack DM (keeps fallback).
Closes #3414.