Skip to content

fix(gateway): scope progress thread fallback to Slack only - #3414

Closed
EmpireOperating wants to merge 2 commits into
NousResearch:mainfrom
EmpireOperating:fix/telegram-progress-thread-metadata
Closed

fix(gateway): scope progress thread fallback to Slack only#3414
EmpireOperating wants to merge 2 commits into
NousResearch:mainfrom
EmpireOperating:fix/telegram-progress-thread-metadata

Conversation

@EmpireOperating

@EmpireOperating EmpireOperating commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Scope event_message_id fallback threading to Slack DMs only.
  • Keep Telegram and other platforms on explicit source.thread_id only for progress metadata.
  • Add regression tests for platform-specific behavior:
    • Telegram DM progress does not use event_message_id as thread_id.
    • Slack DM progress still uses event_message_id fallback.

Upstream parity

  • Upstream already landed Telegram send retry fallback on "Message thread not found" in commit 41d9d08.
  • This PR focuses on the remaining root-cause gap in gateway/run.py: preventing invalid thread metadata from being attached for Telegram DMs in the first place.

Root cause

A Slack-specific progress-thread fallback (source.thread_id or event_message_id) was applied cross-platform. In Telegram DMs, that can pass a normal message ID as message_thread_id (forum-topic-only), triggering BadRequest: Message thread not found and dropped/partial progress streaming.

Validation

  • Added targeted unit tests covering Telegram-vs-Slack progress metadata behavior.
  • Local pytest is unavailable in this runtime (python -m pytest -> No module named pytest), so CI is the source of truth.

@EmpireOperating
EmpireOperating force-pushed the fix/telegram-progress-thread-metadata branch from b3f8cc3 to e77d6fe Compare March 27, 2026 16:04
@EmpireOperating
EmpireOperating force-pushed the fix/telegram-progress-thread-metadata branch from e77d6fe to 76ba25d Compare March 27, 2026 16:42
@EmpireOperating EmpireOperating changed the title fix(gateway): prevent Telegram progress sends from using invalid thread IDs fix(gateway): scope progress thread fallback to Slack only Mar 27, 2026
teknium1 added a commit that referenced this pull request Mar 28, 2026
…3414) (#3488)

* test(gateway): map fixture adapter by platform in progress threading tests

* fix(gateway): scope progress thread fallback to Slack only

---------

Co-authored-by: EmpireOperating <258363005+EmpireOperating@users.noreply.github.com>
@teknium1

Copy link
Copy Markdown
Contributor

Merged via PR #3488. Both commits cherry-picked clean onto current main with authorship preserved. Thanks @EmpireOperating!

angelburgosrosado pushed a commit to angelburgosrosado/hermes-agent that referenced this pull request Apr 27, 2026
…ousResearch#3414) (NousResearch#3488)

* test(gateway): map fixture adapter by platform in progress threading tests

* fix(gateway): scope progress thread fallback to Slack only

---------

Co-authored-by: EmpireOperating <258363005+EmpireOperating@users.noreply.github.com>
02356abc pushed a commit to 02356abc/hermes-agent that referenced this pull request May 14, 2026
…ousResearch#3414) (NousResearch#3488)

* test(gateway): map fixture adapter by platform in progress threading tests

* fix(gateway): scope progress thread fallback to Slack only

---------

Co-authored-by: EmpireOperating <258363005+EmpireOperating@users.noreply.github.com>
gweeteve pushed a commit to gweeteve/hermes-agent that referenced this pull request Jun 2, 2026
…ousResearch#3414) (NousResearch#3488)

* test(gateway): map fixture adapter by platform in progress threading tests

* fix(gateway): scope progress thread fallback to Slack only

---------

Co-authored-by: EmpireOperating <258363005+EmpireOperating@users.noreply.github.com>
waefrebeorn pushed a commit to waefrebeorn/slermes that referenced this pull request Jul 2, 2026
…ousResearch#3414) (NousResearch#3488)

* test(gateway): map fixture adapter by platform in progress threading tests

* fix(gateway): scope progress thread fallback to Slack only

---------

Co-authored-by: EmpireOperating <258363005+EmpireOperating@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants