Skip to content

Don't eager-install camofox in bootstrap installers #34732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rp-keeran wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −6
Open

Don't eager-install camofox in bootstrap installers #34732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/install.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ function Install-AgentBrowser {
$npmLog = [System.IO.Path]::GetTempFileName()
$prevEAP = $ErrorActionPreference
$ErrorActionPreference = "Continue"
& $npm install -g --prefix $prefixDir --silent --ignore-scripts "agent-browser@^0.26.0" "@askjo/camofox-browser@^1.5.2" 2>&1 | Tee-Object -FilePath $npmLog | Out-Null
& $npm install -g --prefix $prefixDir --silent --ignore-scripts "agent-browser@^0.26.0" 2>&1 | Tee-Object -FilePath $npmLog | Out-Null
$npmExit = $LASTEXITCODE
$ErrorActionPreference = $prevEAP
if ($npmExit -ne 0) {
Expand Down
1 change: 0 additions & 1 deletion scripts/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1935,7 +1935,6 @@ ensure_browser() {
log_file="$(mktemp)"
if ! "$npm_bin" install -g --prefix "$HERMES_HOME/node" --silent --ignore-scripts \
"agent-browser@^0.26.0" \
"@askjo/camofox-browser@^1.5.2" \
>"$log_file" 2>&1; then
log_error "npm install failed:"
cat "$log_file" >&2
Expand Down
19 changes: 15 additions & 4 deletions tests/test_package_json_lazy_deps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
"""Invariants for what is eager vs lazy in the root ``package.json``.
"""Invariants for what is eager vs lazy in Node dependency installs.

The root ``package.json`` is installed by ``hermes update`` on every user,
including users who never opted into a given browser backend. Anything
Expand All @@ -23,9 +23,9 @@
"camofox"`` when the user actually selects Camofox.

If a future PR re-adds Camofox (or any other binary-postinstall package)
to root ``dependencies``, this test fails — read the lazy-install
guidance in the ``hermes-agent-dev`` skill before changing the
expectations.
to root ``dependencies`` or the bootstrap installers, this test fails -- read
the lazy-install guidance in the ``hermes-agent-dev`` skill before changing
the expectations.
"""

from __future__ import annotations
Expand Down Expand Up @@ -83,3 +83,14 @@ def test_root_lockfile_has_no_camofox_entries() -> None:
"package-lock.json still references camoufox-js (transitive of "
"@askjo/camofox-browser). Regenerate the lockfile."
)


def test_installers_do_not_eager_install_camofox() -> None:
"""Bootstrap installers must preserve the same lazy Camofox contract."""
for rel_path in ("scripts/install.sh", "scripts/install.ps1"):
text = (REPO_ROOT / rel_path).read_text(encoding="utf-8")
assert "@askjo/camofox-browser" not in text, (
f"{rel_path} eagerly installs @askjo/camofox-browser. Camofox "
"must stay opt-in via the post_setup handler in "
"hermes_cli/tools_config.py."
)