Conversation
install.sh / install.ps1 eagerly installed @askjo/camofox-browser, violating the lazy-install contract documented in test_package_json_lazy_deps (Camofox should be opt-in via post_setup). Drop it from both installers; extend the lazy-deps test to cover the bootstrap scripts.
|
Thanks for identifying the bootstrap regression. The eager installs are still present on current Problems
Suggested changes
Automated hermes-sweeper review. |
GottZ
left a comment
There was a problem hiding this comment.
This was generated by AI during triage.
Summary
Two PRs address the eager Camofox installation path: #27055 removed Camofox from the root dependency graph and established opt-in installation, while #34732 extends that contract to the bootstrap installers but currently removes their install path without restoring a functional on-demand counterpart.
Related pull requests
- #27055 [merged]
related— (+110/-2642) — merged reference implementation: removed@askjo/camofox-browserand its transitive tree from the root package files, explicitly installed it from Camofox post-setup, exposed download progress, and added regression coverage for the lazy-install contract. It remains relevant because #34732 extends the contract established by this merged change to bootstrap installers. - #34732
related— (+16/-6) — keep open, needs changes: correctly removes the eager Camofox argument from both bootstrap installers and adds regression coverage, but does not restore the required lazy-install counterpart. As the contributor keep_open review notes, the current post-setup command has no Camofox package argument, so selecting Camofox would not install@askjo/camofox-browserafter this deletion.
Suggested consolidation
Do not merge #34732 yet; preserve its installer deletions and regression guard, then explicitly install Camofox on demand in the post_setup_key == "camofox" path and align the existence check with that install location. #27055 is the merged reference implementation rather than a duplicate, so no PR should be closed as duplicate.
Cross-PR triage: Reviewed 2 pull requests and 0 issues in this complex. Each diff was read against this issue; Assessment working set: 107 kB of PR diffs, 3 kB of issue/PR text, 3 kB of discussion (2 comments), 0 verify verdicts. verdicts reflect diff content, not PR titles. Part of an automated triage batch.
install.sh/install.ps1eagerly installed@askjo/camofox-browser, violating the lazy-install contract documented intest_package_json_lazy_deps(Camofox should be opt-in via thepost_setuphandler). Drops it from both installers and extends the lazy-deps test to cover the bootstrap scripts.