fix(tools): clarify cronjob required-params to prevent missing-schedule errors - #34483
Closed
teknium1 wants to merge 2 commits into
Closed
fix(tools): clarify cronjob required-params to prevent missing-schedule errors#34483teknium1 wants to merge 2 commits into
teknium1 wants to merge 2 commits into
Conversation
…essage The schema used a top-level allOf if/then to conditionally require schedule, but tools/schema_sanitizer.py strips allOf/anyOf/oneOf from the top-level parameters object (for OpenAI Codex strict-schema compat), so the hint never reached the model. Weak models (Grok 4.3 reporter) then omitted schedule on action=create and hit a terse rejection. Fix lives entirely in metadata that survives sanitization: - action/schedule/prompt/skills descriptions spell out which params each action requires - the create rejection now echoes the received values for debugging Fixes #34120.
Contributor
Author
|
Closing as redundant. The description-driven fix for this exact bug class — flagging that This salvage attempt rewrote those already-present descriptions into a per-action table, which regressed the No code change needed on |
This was referenced Aug 3, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Weak models (Grok 4.3, per #34120) no longer omit
scheduleoncronjob action=createbecause the tool's parameter descriptions now spell out which params each action requires.Root cause: the schema used a top-level
allOfif/then to conditionally requireschedule, buttools/schema_sanitizer.pystripsallOf/anyOf/oneOffrom the top-levelparametersobject (for OpenAI Codex strict-schema compat). The hint was discarded before reaching the LLM, so the model saw onlyrequired: ["action"]and treatedscheduleas optional, then hit the rejection.Changes
tools/cronjob_tools.py:action/schedule/prompt/skillsdescriptions now state per-action required params; the create rejection echoes received values for debugging. All metadata-only — survives sanitization, reaches every backend.scripts/release.py: AUTHOR_MAP entry for the contributor.Validation
required:[action], no schedule hinttests/tools/test_cronjob_tools.pySalvaged from #34173 by @teixeirazeus. Dropped the re-added top-level
allOfblock (stripped by the sanitizer — same dead-on-arrival path as the original) and the issue-specific repro script; kept the effective metadata edits.Fixes #34120.