Skip to content

fix(gateway): separate 429 quota errors from auth failures (#32790) #33780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zccyman wants to merge 1 commit into from
Closed

fix(gateway): separate 429 quota errors from auth failures (#32790) #33780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions gateway/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -908,7 +908,7 @@ def _try_resolve_fallback_provider() -> dict | None:
)
logger.info(
"Fallback provider resolved: %s model=%s",
runtime.get("provider"),
entry.get("provider") or runtime.get("provider"),
entry.get("model"),
)
return {
Expand Down Expand Up @@ -16130,8 +16130,21 @@ def run_sync():
model, runtime_kwargs.get("provider"), session_key or "",
)
except Exception as exc:
# Distinguish rate-limit / quota errors from genuine auth failures
# so the user sees actionable guidance instead of misleading
# "No Codex credentials stored" for transient 429s.
from hermes_cli.auth import AuthError as _AuthError
if isinstance(exc, _AuthError) and exc.code and (
"rate" in (exc.code or "")
or "quota" in (exc.code or "")
or "limit" in (exc.code or "")
):
user_msg = f"⚠️ Provider quota exhausted: {exc}"
logger.warning("Provider rate-limited: %s", exc)
else:
user_msg = f"⚠️ Provider authentication failed: {exc}"
return {
"final_response": f"⚠️ Provider authentication failed: {exc}",
"final_response": user_msg,
"messages": [],
"api_calls": 0,
"tools": [],
Expand Down
Loading
Loading