fix(gateway): separate 429 quota errors from auth failures (#32790) - #33780
Closed
zccyman wants to merge 1 commit into
Closed
fix(gateway): separate 429 quota errors from auth failures (#32790)#33780zccyman wants to merge 1 commit into
zccyman wants to merge 1 commit into
Conversation
…rrect fallback provider name
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32790
Summary
Two fixes in one commit because they share the same code area:
429 quota mislabeled as auth failure (⚠️ Provider quota exhausted: ..." instead of the misleading "⚠️ Provider authentication failed: No Codex credentials stored".
gateway/run.py:16132): Whenresolve_runtime_providerraises anAuthErrorwhosecodeindicates a rate-limit/quota problem (contains "rate", "quota", or "limit"), the gateway now surfaces "Fallback provider log label (
gateway/run.py:910): TheFallback provider resolved:log line now uses the literalproviderkey from the config entry (entry.get("provider")) instead of the normalized provider label returned byresolve_runtime_provider. This fixes the issue whereollamain config was being logged asopenrouter.Changes
gateway/run.py— two targeted patches; no new dependenciesTesting
Existing tests cover the fallback resolution path. The behavioral change (different user-facing message for rate-limit
AuthErrors) is verified by code inspection.