fix(codex): handle None response.output from SDK get_final_response (fixes #32908) - #32919
Closed
Morad37 wants to merge 2 commits into
Closed
fix(codex): handle None response.output from SDK get_final_response (fixes #32908)#32919Morad37 wants to merge 2 commits into
Morad37 wants to merge 2 commits into
Conversation
…d agents don't orphan jobs (fixes NousResearch#32091)
2 tasks
Contributor
|
Closing as duplicate — the Codex null-output fix has been merged via #32963 (cherry-picked from @carltonawong's PR #32890). Thanks for the help during the outage. Closes #11179. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the Codex backend omits the
response.completedterminal event, the OpenAI SDK'sparse_response()crashes withTypeError: 'NoneType' object is not iterableat line 61 of_parsing/_responses.py- becauseresponse.outputisNoneinstead of[]. This TypeError bypasses the existing backfill logic at codex_runtime.py:250-273 designed exactly for this scenario.Fix
Catch
TypeErroronstream.get_final_response()and setoutput=[]on a minimal response object. The existing backfill then reconstructs output from already-collected stream items (collected_output_items) or synthesized text deltas - preserving data and avoiding a fresh API call (no double-billing).The existing exception handler at line 302 caught
RuntimeErrorbut notTypeError, so the crash jumped past every recovery path and escalated as a non-retryable client error.Testing
Bug is reproducible with
hermes chat -q "say the word ok" --provider openai-codex -m gpt-5.5(45+ times per session per the reporter).Closes #32908