fix(codex): recover from null terminal output in Responses streams - #32900
Closed
bananawalnut wants to merge 1 commit into
Closed
fix(codex): recover from null terminal output in Responses streams#32900bananawalnut wants to merge 1 commit into
bananawalnut wants to merge 1 commit into
Conversation
This was referenced May 27, 2026
Closed
Contributor
|
Closing as duplicate — the Codex null-output fix has been merged via #32963 (cherry-picked from @carltonawong's PR #32890, the one Gille reviewed). Thanks for jumping on the outage so quickly; appreciate the help. Closes #11179. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeError: 'NoneType' object is not iterableon a terminal nullresponse.outputresponse.output_item.doneevents when possiblecreate(stream=True)parser when no recoverable streamed payload existsWhy
The ChatGPT Codex backend can close a Responses stream with a terminal frame that has no output list. OpenAI Python SDK 2.24.0 raises while iterating that field, even though Hermes may already have received usable streamed output-item events. This made Hermes abort with a non-retryable client error.
Tests
uv run --python 3.13 --with pytest pytest tests/run_agent/test_run_agent_codex_responses.py -o 'addopts=' -quv run --python 3.13 python -m py_compile agent/codex_runtime.py tests/run_agent/test_run_agent_codex_responses.pyCloses #32894