fix(paths): respect HERMES_HOME for protected Hermes env path - #3232
Closed
erhnysr wants to merge 1 commit into
Closed
fix(paths): respect HERMES_HOME for protected Hermes env path#3232erhnysr wants to merge 1 commit into
erhnysr wants to merge 1 commit into
Conversation
Contributor
Author
|
The failing test may be expecting the hardcoded This PR updates the path resolution to respect Happy to update tests if needed. |
Contributor
Author
|
Added the legacy |
teknium1
added a commit
that referenced
this pull request
Mar 30, 2026
…3840) The write-deny list in file_operations.py hardcoded ~/.hermes/.env, which misses the actual .env in custom HERMES_HOME or profile setups. Use get_hermes_home() for profile-safe path resolution. Salvaged from PR #3232 by @erhnysr. Co-authored-by: Erhnysr <erhnysr@users.noreply.github.com>
Contributor
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
…ousResearch#3840) The write-deny list in file_operations.py hardcoded ~/.hermes/.env, which misses the actual .env in custom HERMES_HOME or profile setups. Use get_hermes_home() for profile-safe path resolution. Salvaged from PR NousResearch#3232 by @erhnysr. Co-authored-by: Erhnysr <erhnysr@users.noreply.github.com>
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…ousResearch#3840) The write-deny list in file_operations.py hardcoded ~/.hermes/.env, which misses the actual .env in custom HERMES_HOME or profile setups. Use get_hermes_home() for profile-safe path resolution. Salvaged from PR NousResearch#3232 by @erhnysr. Co-authored-by: Erhnysr <erhnysr@users.noreply.github.com>
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
…ousResearch#3840) The write-deny list in file_operations.py hardcoded ~/.hermes/.env, which misses the actual .env in custom HERMES_HOME or profile setups. Use get_hermes_home() for profile-safe path resolution. Salvaged from PR NousResearch#3232 by @erhnysr. Co-authored-by: Erhnysr <erhnysr@users.noreply.github.com>
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
…ousResearch#3840) The write-deny list in file_operations.py hardcoded ~/.hermes/.env, which misses the actual .env in custom HERMES_HOME or profile setups. Use get_hermes_home() for profile-safe path resolution. Salvaged from PR NousResearch#3232 by @erhnysr. Co-authored-by: Erhnysr <erhnysr@users.noreply.github.com>
Sarthib7
added a commit
to Sarthib7/hermes-agent
that referenced
this pull request
Jul 14, 2026
The live Task.status enum gained QUEUED (accepted by a coworker, waiting to start; sokosumi PR NousResearch#3232, 2026-06-22) and APPROVAL_REQUIRED (blocked on human approval; sokosumi PR NousResearch#3180, 2026-06-15) — verified against https://api.sokosumi.com/v1/openapi.json on 2026-07-14. Add APPROVAL_REQUIRED to the helper's TASK_BLOCKED set so 'wait task' exits 2 (blocked) instead of polling to timeout, update the SKILL.md status table to the 14-value task enum, and reword the QUEUED pitfall (it is a task-only status; still never a job or job-event status). Two new tests; 39 total.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the protected write deny list to respect
HERMES_HOMEinstead of using a hardcoded~/.hermes/.envpath.Why
The deny list should follow the active Hermes profile. Hardcoding
~/.hermes/.envbypassesHERMES_HOMEand can miss the actual protected env file in custom or multi-instance setups.Changes
tools/file_operations.pyget_hermes_home()for consistency with the rest of the codebaseScope
Minimal path-consistency fix with no behavior change beyond correctly respecting
HERMES_HOME.