Skip to content

fix(paths): use get_hermes_home() instead of hardcoded ~/.hermes - #3205

Closed
erhnysr wants to merge 1 commit into
NousResearch:mainfrom
erhnysr:fix/hermes-home-regression-audit
Closed

fix(paths): use get_hermes_home() instead of hardcoded ~/.hermes#3205
erhnysr wants to merge 1 commit into
NousResearch:mainfrom
erhnysr:fix/hermes-home-regression-audit

Conversation

@erhnysr

@erhnysr erhnysr commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Replaces hardcoded ~/.hermes usage with get_hermes_home().

Why

Hardcoded paths bypass the HERMES_HOME environment variable, breaking custom setups and multi-instance usage.

Changes

  • Replaced Path("~/.hermes") with get_hermes_home()

Scope

Minimal and safe change — no behavior modification beyond respecting HERMES_HOME.

@erhnysr

erhnysr commented Mar 26, 2026

Copy link
Copy Markdown
Contributor Author

The failing tests appear unrelated to this change.

This PR only replaces a hardcoded path with get_hermes_home(), and does not affect ACP or auth-related modules.

Happy to investigate further if needed, but this seems to be a pre-existing issue.

@binhnt92

Copy link
Copy Markdown
Contributor

nice catch — #1233 did a sweep of these hardcoded paths back in March but looks like this one in file_tools.py slipped through

@teknium1

Copy link
Copy Markdown
Contributor

Already fixed on main via commit e97c0cb (PR #3575 prep work). The hardcoded path in file_tools.py was replaced with get_hermes_home() in that commit. Thanks @erhnysr — your sibling PR #3232 was still needed and merged via #3840!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants