fix(paths): use get_hermes_home() instead of hardcoded ~/.hermes - #3205
Closed
erhnysr wants to merge 1 commit into
Closed
fix(paths): use get_hermes_home() instead of hardcoded ~/.hermes#3205erhnysr wants to merge 1 commit into
erhnysr wants to merge 1 commit into
Conversation
Contributor
Author
|
The failing tests appear unrelated to this change. This PR only replaces a hardcoded path with get_hermes_home(), and does not affect ACP or auth-related modules. Happy to investigate further if needed, but this seems to be a pre-existing issue. |
Contributor
|
nice catch — #1233 did a sweep of these hardcoded paths back in March but looks like this one in file_tools.py slipped through |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces hardcoded ~/.hermes usage with get_hermes_home().
Why
Hardcoded paths bypass the HERMES_HOME environment variable, breaking custom setups and multi-instance usage.
Changes
Scope
Minimal and safe change — no behavior modification beyond respecting HERMES_HOME.