chore: ruff auto-fix C4 series - #31825
Closed
wesleysimplicio wants to merge 1 commit into
Closed
Conversation
Auto-fix for C401 (unnecessary-generator-set), C408
(unnecessary-collection-call), and C416 (unnecessary-comprehension).
Semantically safe — dict() -> {}, list() -> [], set(x for ...) -> {...}.
No behavior change.
Collaborator
|
@christian-byrne Tagging you on this ComfyUI item. |
alt-glitch
added
type/refactor
This was referenced Jun 8, 2026
Contributor
Author
|
Closing non-fix PR as requested — mantendo apenas PRs de fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the
C4lint rule group to pyproject.toml and appliesruff check --fix --unsafe-fixesacross 21 files.Rules: C401 (unnecessary-generator-set:
set(x for x in y)→{x for x in y}), C408 (unnecessary-collection-call:dict()→{},list()→[]), C416 (unnecessary-comprehension:[x for x in y]→list(y))Root cause
The detailed rationale from the original PR body is preserved below. This template update keeps the review structure consistent with #29640.
Fix
Why this shape
This shape mirrors #29640 so reviewers can quickly compare scope, root cause, fix, tests, and related context without having to decode a custom PR description.
Tests
ruff checkpassa com zero erros (regra já ativa na config)pytestmantém o comportamento esperadoGenerated by Hermes Turbo
Related PRs / issues
Original body
Summary
Adds the
C4lint rule group to pyproject.toml and appliesruff check --fix --unsafe-fixesacross 21 files.Rules: C401 (unnecessary-generator-set:
set(x for x in y)→{x for x in y}), C408 (unnecessary-collection-call:dict()→{},list()→[]), C416 (unnecessary-comprehension:[x for x in y]→list(y))What Changed
pyproject.toml: addedC4to[tool.ruff.lint] selectFluxo
O ruff percorre a árvore do projeto aplicando a regra
C4onde encontra violações. As transformações foram feitas por auto-fix e mantêm o comportamento do código.Visão
Com a regra habilitada no lint, o projeto passa a bloquear regressões futuras no mesmo padrão e fica mais consistente para novos commits.
Test Plan
ruff checkpassa com zero erros (regra já ativa na config)pytestmantém o comportamento esperadoGenerated by Hermes Turbo
Generated by Hermes Turbo