Skip to content

[codex] Fix docs image base URLs - #31554

Closed
GarlicGo wants to merge 1 commit into
NousResearch:mainfrom
GarlicGo:codex/fix-session-recap-doc-image
Closed

GarlicGo wants to merge 1 commit into
NousResearch:mainfrom
GarlicGo:codex/fix-session-recap-doc-image

Conversation

@GarlicGo

Copy link
Copy Markdown
Contributor

Summary

  • Use Docusaurus useBaseUrl() for raw HTML docs figures so static image paths include the /docs base URL.
  • Fix the session recap figure from [Bug]: session-recap.svg not loading in docs #24809 and the adjacent CLI layout figure with the same root-path pattern.

Root cause

The docs site is configured with baseUrl: "/docs/", but raw HTML <img> tags kept absolute /img/docs/... paths. In production those resolve outside the docs base path and can 404 even though the static asset exists.

Fixes #24809

Validation

  • npm run build from website/ completed with exit code 0. Existing Docusaurus broken-link/broken-anchor warnings remain unrelated.
  • Verified generated HTML includes /docs/img/docs/session-recap.svg and /docs/img/docs/cli-layout.svg, with no remaining root /img/docs/... path for those figures.

@alt-glitch alt-glitch added type/docs Documentation improvements P3 Low — cosmetic, nice to have duplicate This issue or pull request already exists labels May 24, 2026
@alt-glitch

Copy link
Copy Markdown
Contributor

Duplicate of #24824 (and overlaps with #27394 which was already marked duplicate of #24824). All three PRs fix the same useBaseUrl() / base path issue for docs image <img> tags in sessions.md and cli.md. #24824 uses the idiomatic Docusaurus approach.

@GarlicGo
GarlicGo marked this pull request as ready for review May 24, 2026 17:24
@GarlicGo GarlicGo closed this May 24, 2026
@GarlicGo

Copy link
Copy Markdown
Contributor Author

Duplicate of #24824 (and overlaps with #27394 which was already marked duplicate of #24824). All three PRs fix the same useBaseUrl() / base path issue for docs image <img> tags in sessions.md and cli.md. #24824 uses the idiomatic Docusaurus approach.

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have type/docs Documentation improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: session-recap.svg not loading in docs

2 participants