Skip to content

docs: fix session recap image path - #27394

Closed
nielskaspers wants to merge 1 commit into
NousResearch:mainfrom
nielskaspers:docs/24809-session-recap-image
Closed

docs: fix session recap image path#27394
nielskaspers wants to merge 1 commit into
NousResearch:mainfrom
nielskaspers:docs/24809-session-recap-image

Conversation

@nielskaspers

Copy link
Copy Markdown
Contributor

Fixes #24809.

The docs site is served with baseUrl: "/docs/", so an image src that starts with /img/... points to the wrong absolute path in production.

This updates the Sessions doc to resolve the static asset via useBaseUrl("/img/docs/session-recap.svg"), so the image loads correctly under /docs/.

@alt-glitch alt-glitch added type/docs Documentation improvements P3 Low — cosmetic, nice to have labels May 17, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Duplicate of #24824, which also fixes #24809 with the more idiomatic useBaseUrl() Docusaurus approach. This PR hardcodes /docs/ prefix instead, which is brittle. Note: this PR additionally fixes cli-layout.svg in cli.md which #24824 does not cover — that fix could be cherry-picked into #24824.

@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the docs fix — this is already implemented on current main, so this PR is now safe to close as covered.

Evidence from this automated hermes-sweeper review:

  • website/docs/user-guide/sessions.md:7 on current main imports useBaseUrl from @docusaurus/useBaseUrl.
  • website/docs/user-guide/sessions.md:149 on current main renders the recap image with src={useBaseUrl('/img/docs/session-recap.svg')}.
  • The implementing commit is 6891e05e78b67beac3ef4f2f5acbdbd24f4e9e7b (docs: fix session recap image baseUrl), which is contained in tag v2026.6.5.

The related report #24809 is also closed, and the useful prior discussion about duplicate fixes was accounted for.

@teknium1 teknium1 closed this Jun 13, 2026
@teknium1 teknium1 added the sweeper:implemented-on-main Sweeper: behavior already present on current main label Jun 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low — cosmetic, nice to have sweeper:implemented-on-main Sweeper: behavior already present on current main type/docs Documentation improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: session-recap.svg not loading in docs

3 participants