Skip to content

fix(delegate): wire model/provider params through to _build_child_agent #31284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Altairpaca wants to merge 1 commit into from
Closed

fix(delegate): wire model/provider params through to _build_child_agent #31284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions tools/delegate_tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1924,6 +1924,8 @@ def delegate_task(
acp_command: Optional[str] = None,
acp_args: Optional[List[str]] = None,
role: Optional[str] = None,
model: Optional[str] = None,
provider: Optional[str] = None,
parent_agent=None,
) -> str:
"""
Expand Down Expand Up @@ -1997,6 +1999,15 @@ def delegate_task(
except ValueError as exc:
return tool_error(str(exc))

# Per-call model/provider override takes priority over delegation config
if model is not None:
creds["model"] = model
if provider is not None:
creds["provider"] = provider
creds["base_url"] = None
creds["api_key"] = None
creds["api_mode"] = None

# Normalize to task list
max_children = _get_max_concurrent_children()
recovered_tasks, tasks_error = _recover_tasks_from_json_string(tasks)
Expand All @@ -2017,7 +2028,7 @@ def delegate_task(
task_list = tasks
elif goal and isinstance(goal, str) and goal.strip():
task_list = [
{"goal": goal, "context": context, "toolsets": toolsets, "role": top_role}
{"goal": goal, "context": context, "toolsets": toolsets, "role": top_role, "model": model, "provider": provider}
]
else:
return tool_error("Provide either 'goal' (single task) or 'tasks' (batch).")
Expand Down Expand Up @@ -2058,16 +2069,18 @@ def delegate_task(
# Per-task role beats top-level; normalise again so unknown
# per-task values warn and degrade to leaf uniformly.
effective_role = _normalize_role(t.get("role") or top_role)
task_model = t.get("model") if t.get("model") is not None else creds["model"]
task_provider = t.get("provider") if t.get("provider") is not None else creds["provider"]
child = _build_child_agent(
task_index=i,
goal=t["goal"],
context=t.get("context"),
toolsets=t.get("toolsets") or toolsets,
model=creds["model"],
model=task_model,
max_iterations=effective_max_iter,
task_count=n_tasks,
parent_agent=parent_agent,
override_provider=creds["provider"],
override_provider=task_provider,
override_base_url=creds["base_url"],
override_api_key=creds["api_key"],
override_api_mode=creds["api_mode"],
Expand Down