fix(delegate): wire model/provider params through to _build_child_agent - #31284
Closed
Altairpaca wants to merge 1 commit into
Closed
fix(delegate): wire model/provider params through to _build_child_agent#31284Altairpaca wants to merge 1 commit into
Altairpaca wants to merge 1 commit into
Conversation
The delegate_task() function already declared model and provider parameters in its signature (lines 1924-1925) and documented them in the docstring, but they were never actually passed through to _build_child_agent(). Three missing links added: 1. Single-task dict now includes model/provider so they reach the batch loop 2. Per-call model/provider override creds after credential resolution from config 3. Per-task model/provider resolution in the batch iteration loop This lets callers do: delegate_task(goal="...", model="deepseek-v4-pro") to run a subagent on a specific model, with per-task overrides in batch mode. When unset, children inherit from parent (existing behaviour preserved).
Collaborator
Author
|
Thanks for the pointer! #3172 by @ReqX is indeed the earliest in this cluster. Our commit is against the current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The delegate_task() function already declared model and provider parameters in its signature (lines 1924-1925) and documented them in the docstring, but they were never actually passed through to _build_child_agent().
Three missing links added:
This lets callers do:
delegate_task(goal="...", model="deepseek-v4-pro")
to run a subagent on a specific model, with per-task overrides in batch mode. When unset, children inherit from parent (existing behaviour preserved).
What does this PR do?
Related Issue
Fixes #
Type of Change
Changes Made
How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
hermes --toolsets skills -q "Use the X skill to do Y"Screenshots / Logs