feat(discord): allow free-response channel auto-threading - #30110
Closed
noahbare wants to merge 1 commit into
Closed
feat(discord): allow free-response channel auto-threading#30110noahbare wants to merge 1 commit into
noahbare wants to merge 1 commit into
Conversation
Collaborator
|
Duplicate of #17564 — this is the sixth implementation of the same feature (auto-threading in free-response Discord channels). Other open PRs for the same feature: #17564, #18455, #27651, #13958. Please coordinate with maintainers on a single implementation rather than submitting another competing PR. |
Author
|
Should have searched better. I don't care what makes it in, I just don't want to have to maintain a fork for a super easy change. Will close and push for one of the others, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
discord.auto_thread_free_response_channels/DISCORD_AUTO_THREAD_FREE_RESPONSE_CHANNELSas an opt-in setting.discord.no_thread_channelsas the explicit override when both settings apply.Test Plan
python -m pytest tests/gateway/test_discord_free_response.py tests/gateway/test_discord_channel_controls.pyNo linked issue/task — this should be fine as a standalone PR unless maintainers want it associated after review.