fix(discord): restore auto-threading in free-response channels - #13958
chhotu-claw wants to merge 1 commit into
Conversation
|
Thanks for the careful work here — clean diff, test, and docs all moved together. We're going to keep the current behavior (free-response channels reply inline, auto-threading skipped) and close this one. The reasoning: The The underlying tension in #12750 is real, though: one user wants free-response and threads. The right fix is to decouple the two concerns rather than flip the global default — keep free-response inline, and let someone who wants threads opt in explicitly (e.g. listing the channel under Note also the branch is stale: Appreciate the contribution — closing as we're keeping the inline default, not because the work was wrong. |
Summary
discord.no_thread_channelsas the explicit inline-reply escape hatchTest Plan
python3 -m pytest tests/gateway/test_discord_free_response.py::test_discord_free_channel_still_auto_threads -qPYTHONPATH="/tmp${PYTHONPATH:+:$PYTHONPATH}" source "$HOME/.hermes/hermes-agent/venv/bin/activate" && PYTHONPATH="/tmp${PYTHONPATH:+:$PYTHONPATH}" scripts/run_tests.sh tests/gateway/test_discord_free_response.py tests/gateway/test_discord_channel_controls.py -qFixes #12750