chore: rebase #25968 (xai-oauth) on latest main + fix review issues - #27148
chore: rebase #25968 (xai-oauth) on latest main + fix review issues#27148avirweb wants to merge 2 commits into
Conversation
This comment was marked as spam.
This comment was marked as spam.
dcda76d to
be59e1a
Compare
…s, runtime exceptions, fromisoformat Z, expires_in coercion
be59e1a to
4b7d7eb
Compare
|
Closing this one. The premise "the official is kinda broken, this fixes it" doesn't hold up against the current state of main. xAI Grok OAuth officially landed via #26534 on May 15 and has had five follow-up hardenings merged since:
Re-rebasing #25968 wholesale on top of all that is not a useful diff shape. If something specific is still broken on current main, the right move is to file an issue with reproducible steps against the merged version (or open a narrow PR fixing the specific bug), not to re-land an old branch as a "rebase." Thanks for tracking it — and credit to @ams432 for the original work, which is already in main. |
Rebase of am423's PR #25968 onto latest upstream main, with audit fixes for the review issues surfaced on that PR.
What this is
This is not a new feature. It's a rebase + cleanup of the existing open PR #25968 (feat/xai-oauth-first-class), which was stale and had merge conflicts. While rebasing, the following issues were also fixed:
Fixes
Supersedes #25968, #27144.