fix(codex): suppress commentary phase leakage - #26898
Draft
yolopsx wants to merge 2 commits into
Draft
Conversation
Collaborator
This was referenced Jun 23, 2026
This was referenced Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commentary/analysisphase text from visible assistant content.output_text.deltais cached, not emitted to platform callbacks before phase-aware normalization.Why
commentaryandanalysiscan contain internal planning. They should not appear in Telegram/CLI/UI output unless a final-answer phase is present.Test Plan
venv/bin/python -m pytest tests/run_agent/test_run_agent_codex_responses.py tests/run_agent/test_streaming.py::TestCodexStreamCallbacks -q67 passed in 18.80sNotes
Opened as draft because this is a visibility/privacy hardening change and maintainers may want to review provider replay semantics carefully.