fix(codex): keep commentary out of visible content - #21568
Closed
callexcapital wants to merge 1 commit into
Closed
Conversation
19 tasks
This was referenced Jul 5, 2026
Contributor
|
The Codex commentary-phase leak this PR targeted is now fixed on main via PR #58868, which salvaged #58696 (broadest coverage: adapter + streaming + fallback) combined with #41343's reasoning-channel routing. Commentary/analysis-phase text now displays like thinking instead of leaking as visible content, in both normalized responses and live stream deltas. You were the earliest submitter in this cluster — thank you for identifying and fixing the leak first. Closing since the fix that landed takes a different mechanism (phase-based routing at the adapter/runtime layer rather than callback sanitization). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Need inspect...commentary leak with a real tool callRelated
Test plan
pytest tests/run_agent/test_run_agent_codex_responses.py -q -o 'addopts='→ 60 passedpytest tests/run_agent/test_deepseek_reasoning_content_echo.py tests/gateway/test_session_boundary_security_state.py -q -o 'addopts='→ 41 passed