fix(profiles): detect systemd-managed gateways in profile list/show - #26731
Open
Zyrixtrex wants to merge 1 commit into
Open
fix(profiles): detect systemd-managed gateways in profile list/show#26731Zyrixtrex wants to merge 1 commit into
Zyrixtrex wants to merge 1 commit into
Conversation
Collaborator
Contributor
|
Thanks for addressing the profile-status/systemd mismatch. The premise remains live on current main: Problems
Suggested changes
Automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes profile listandhermes profile show <name>could reportGateway: stoppedeven when the gateway was actually running as a systemd-managed service.
This happened because profile status checks only looked at
gateway.pid.For host-side systemd setups, that could miss a live gateway that other Hermes
surfaces already detected correctly.
What changed
hermes_cli.gatewayservice-name/unit-path helpers to accept an explicithermes_homehermes_cli.profiles._check_gateway_running()to:gateway.pidcheck firstFalseReproduction
hermes gateway statusreports it as runninghermes profile listorhermes profile show defaultBefore this change:
Gateway: stoppedAfter this change:
Files changed
hermes_cli/gateway.pyhermes_cli/profiles.pytests/hermes_cli/test_profiles.pyHow to test