fix(profile): detect service-managed gateway status - #20488
Open
LeonSGP43 wants to merge 1 commit into
Open
Conversation
alt-glitch
added
type/bug
austinpickett
requested changes
May 18, 2026
austinpickett
left a comment
austinpickett
left a comment
Collaborator
There was a problem hiding this comment.
Please use PULL_REQUEST_TEMPLATE.md
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes #20254 by teaching profile status reporting to recognize service-managed (systemd/launchd) gateways. The existing per-profile gateway.pid lookup is kept as a fast path; when no pid file is found, _check_gateway_running temporarily scopes HERMES_HOME to the profile being inspected and consults get_gateway_runtime_snapshot() so service-managed gateways are correctly reported by hermes profile list/show.
Changes:
- Add a service-manager fallback in
hermes_cli/profiles._check_gateway_runningwhen the profile'sgateway.pidis absent. - Temporarily scope
HERMES_HOMEto the target profile around the snapshot call soget_service_name()resolves the right systemd unit. - Add regression test (
test_gateway_running_check_uses_runtime_snapshot_fallback) and update the existing tests to mock the new snapshot dependency.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| hermes_cli/profiles.py | Adds the service-manager runtime-snapshot fallback inside _check_gateway_running, with HERMES_HOME save/restore. |
| tests/hermes_cli/test_profiles.py | Mocks get_gateway_runtime_snapshot in the existing tests and adds a regression test verifying the no-pid-file service fallback path and HERMES_HOME restoration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+364
to
377
| try: | ||
| from hermes_cli.gateway import get_gateway_runtime_snapshot | ||
| previous_home = os.environ.get("HERMES_HOME") | ||
| os.environ["HERMES_HOME"] = str(profile_dir) | ||
| try: | ||
| snapshot = get_gateway_runtime_snapshot() | ||
| return bool(getattr(snapshot, "service_running", False)) | ||
| finally: | ||
| if previous_home is None: | ||
| os.environ.pop("HERMES_HOME", None) | ||
| else: | ||
| os.environ["HERMES_HOME"] = previous_home | ||
| except Exception: | ||
| return False |
Comment on lines
+366
to
+375
| previous_home = os.environ.get("HERMES_HOME") | ||
| os.environ["HERMES_HOME"] = str(profile_dir) | ||
| try: | ||
| snapshot = get_gateway_runtime_snapshot() | ||
| return bool(getattr(snapshot, "service_running", False)) | ||
| finally: | ||
| if previous_home is None: | ||
| os.environ.pop("HERMES_HOME", None) | ||
| else: | ||
| os.environ["HERMES_HOME"] = previous_home |
Comment on lines
355
to
377
| try: | ||
| from gateway.status import get_running_pid | ||
| return get_running_pid(profile_dir / "gateway.pid", cleanup_stale=False) is not None | ||
| if ( | ||
| get_running_pid(profile_dir / "gateway.pid", cleanup_stale=False) | ||
| is not None | ||
| ): | ||
| return True | ||
| except Exception: | ||
| pass | ||
| try: | ||
| from hermes_cli.gateway import get_gateway_runtime_snapshot | ||
| previous_home = os.environ.get("HERMES_HOME") | ||
| os.environ["HERMES_HOME"] = str(profile_dir) | ||
| try: | ||
| snapshot = get_gateway_runtime_snapshot() | ||
| return bool(getattr(snapshot, "service_running", False)) | ||
| finally: | ||
| if previous_home is None: | ||
| os.environ.pop("HERMES_HOME", None) | ||
| else: | ||
| os.environ["HERMES_HOME"] = previous_home | ||
| except Exception: | ||
| return False |
teknium1
reviewed
Jul 12, 2026
teknium1
left a comment
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for targeting the service-managed no-PID path; current main still has a related systemd gap.
Problems
hermes_cli/profiles.py:368temporarily writesos.environ["HERMES_HOME"]. That environment is process-global, so another dashboard/request thread can observe the displayed profile and use the wrong home.hermes_constants.py:23-35providesset_hermes_home_override()specifically for per-task scoping without mutating the environment.- The new test validates that global mutation rather than proving the profile-specific service probe is isolated.
Suggested changes
- Scope
get_gateway_runtime_snapshot()withset_hermes_home_override(str(profile_dir))and reset its token infinally. - Add coverage that the snapshot resolves the target profile while an independent context retains its original home.
Automated hermes-sweeper review.
| from hermes_cli.gateway import get_gateway_runtime_snapshot | ||
| previous_home = os.environ.get("HERMES_HOME") | ||
| os.environ["HERMES_HOME"] = str(profile_dir) | ||
| try: |
Contributor
There was a problem hiding this comment.
os.environ is shared by every thread. Please use hermes_constants.set_hermes_home_override(str(profile_dir)) and reset its token in finally; this scopes the snapshot to this operation without exposing another profile to concurrent dashboard/request work.
teknium1
added
sweeper:risk-session-state
This was referenced Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #20254
Verification
scripts/run_tests.sh tests/hermes_cli/test_profiles.py -k gateway_running_checkscripts/run_tests.sh tests/hermes_cli/test_profiles.pyNon-goals