Skip to content

fix(process_registry): poll() must not mark completion as consumed (#10156) #26659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
someaka wants to merge 1 commit into from
Closed

fix(process_registry): poll() must not mark completion as consumed (#10156) #26659

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tools/process_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,7 +823,7 @@ def _move_to_finished(self, session: ProcessSession):
# ----- Query Methods -----

def is_completion_consumed(self, session_id: str) -> bool:
"""Check if a completion notification was already consumed via wait/poll/log."""
"""Check if a completion notification was already consumed via wait/read_log."""
return session_id in self._completion_consumed

def drain_notifications(self) -> "list[tuple[dict, str]]":
Expand Down Expand Up @@ -949,7 +949,6 @@ def poll(self, session_id: str) -> dict:
}
if session.exited:
result["exit_code"] = session.exit_code
self._completion_consumed.add(session_id)
if session.detached:
result["detached"] = True
result["note"] = "Process recovered after restart -- output history unavailable"
Expand Down