fix(process_registry): poll() must not mark completion as consumed (#10156) - #26659
Closed
someaka wants to merge 1 commit into
Closed
fix(process_registry): poll() must not mark completion as consumed (#10156)#26659someaka wants to merge 1 commit into
someaka wants to merge 1 commit into
Conversation
Collaborator
Author
This was referenced May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10156.
Problem
Commit f53a5a7 (#8228) added
_completion_consumedtracking to suppress duplicatenotify_on_completenotifications. The fix was correct forwait()(blocking call = output consumed), but was incorrectly extended topoll()(read-only query = should have no side effects).Consequence: when the agent calls
process(action='poll')on an exited background process,poll()marks the completion as consumed. The watcher thread (which checksis_completion_consumed()before injecting the notification) seesTrueand skips the notification. The user never sees the background process completion message.Fix
Two changes, both in
tools/process_registry.py:self._completion_consumed.add(session_id)frompoll()is_completion_consumed()docstring: poll → read_logOnly
wait()andread_log()should mark completion as consumed.poll()is a read-only query with no side effects.