Skip to content

fix(cli): await run_in_terminal futures to prevent RuntimeWarning #26617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
laychiman wants to merge 1 commit into from
Closed

fix(cli): await run_in_terminal futures to prevent RuntimeWarning #26617

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6482,7 +6482,12 @@ def _pick():
self._status_bar_visible = False
self._app.invalidate()
try:
run_in_terminal(_pick)
_future = run_in_terminal(_pick)
# run_in_terminal returns an Awaitable/Future in prompt_toolkit 3.0+.
# Block until it completes so the coroutine isn't orphaned.
_done = threading.Event()
_future.add_done_callback(lambda f: _done.set())
_done.wait(timeout=60)
finally:
self._status_bar_visible = was_visible
self._app.invalidate()
Expand Down Expand Up @@ -6519,7 +6524,12 @@ def _ask():
self._status_bar_visible = False
self._app.invalidate()
try:
run_in_terminal(_ask)
_future = run_in_terminal(_ask)
# run_in_terminal returns an Awaitable/Future in prompt_toolkit 3.0+.
# Block until it completes so the coroutine isn't orphaned.
_done = threading.Event()
_future.add_done_callback(lambda f: _done.set())
_done.wait(timeout=60)
except Exception:
# WSL / Warp / certain terminal emulators silently drop the
# scheduled coroutine. Fall back to a direct input() so the
Expand Down