fix(cli): await run_in_terminal futures to prevent RuntimeWarning

[laychiman]

Problem

prompt_toolkit.application.run_in_terminal() returns an Awaitable[_T] (an asyncio.Future) since prompt_toolkit 3.0+. Hermes discards the return value at two call sites, triggering:

RuntimeWarning: coroutine 'run_in_terminal.<locals>.run' was never awaited

Affects /new, /reset, /undo slash commands dispatched from the process_loop daemon thread.

Fix

Capture the returned Future and block until completion via threading.Event + add_done_callback, with a 60s timeout.

Changed

• _run_curses_picker() — block on _pick() future
• _prompt_text_input() — block on _ask() future

Why not asyncio.ensure_future()?

These call sites depend on result[0] being set before returning, so fire-and-forget is insufficient. The threading.Event pattern ensures the scheduled coroutine completes before we read the result.

Related

• Fixes [Bug]: RuntimeWarning “run_in_terminal... was never awaited” when confirming /clear or /new in CLI #23297
• Fixes fix(cli): RuntimeWarning in /new, /clear, /undo, /reload-mcp — coroutine was never awaited #22970
• Complements Bartok9's fix: 4 small surgical bugs — kanban delete alias, gateway title noise, bg truncation, cprint coroutine #23302 (which fixes _pt_print_safe._schedule via ensure_future)

[alt-glitch]

Related: Fixes #22970 and #23297. Competing fix PRs for the same root cause: #22851, #22972, #22987, #23210, #23317. Also complements #23302 (mentioned in body).

[teknium1]

This looks implemented on current main via the merged alternate fix path.

Evidence from this automated hermes-sweeper review:

• c5f1f863acd49c92d9fbe92550115d51dd5181d0 / fix(cli): drive _prompt_text_input directly when off main thread (#23185) #23454 fixed the slash-command process_loop daemon-thread path by bypassing run_in_terminal off the main prompt_toolkit thread.
• Current cli.py:6287 documents that run_in_terminal returns a coroutine driven by the main-thread event loop, and cli.py:6306 only calls it when self._app exists and the current thread is the main thread; daemon-thread slash commands fall back to direct input().
• Current cli.py:6257 applies the same main-thread guard to _run_curses_picker, so the process_loop background-thread path calls _pick() directly instead of orphaning a coroutine.
• The related fix: 4 small surgical bugs — kanban delete alias, gateway title noise, bg truncation, cprint coroutine #23302 complement mentioned in this PR was also salvaged in 365da2d2dfd92bd16f1993c8fefea05508282db8, which schedules the fire-and-forget _cprint run_in_terminal coroutine via asyncio.ensure_future.

Thanks for the PR and the clear analysis. The specific warning path it targeted has been resolved on main by the merged fixes above.