Conversation
- Add Windows detection in _detect_target() returning x86_64-pc-windows-msvc - Handle .zip archive format for Windows releases (vs .tar.gz for Linux/macOS) - Use tirith.exe binary name on Windows - Fixes #26044
alt-glitch
added
type/bug
Contributor
Author
|
Closing as there are duplicate PRs addressing this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #26044
The Tirith security scanner auto-install was failing on Windows with
unsupported_platformerror because_detect_target()only handled Darwin and Linux/Android.Changes
_detect_target()returningx86_64-pc-windows-msvc.zipformat (vs.tar.gzfor Linux/macOS)tirith.exeon WindowsTesting
platform.system()returns'Windows'on Windowsplatform.machine()returns'AMD64'or'x86_64'on Windows.zipand.tar.gzformatsNotes