Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion plugins/kanban/dashboard/plugin_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -868,7 +868,17 @@ def bulk_update(payload: BulkTaskBody, board: Optional[str] = Query(None)):
ok = kanban_db.unblock_task(conn, tid)
else:
ok = _set_status_direct(conn, tid, "ready")
elif s in ("todo", "running", "triage"):
elif s == "running":
entry.update(
ok=False,
error=(
"Cannot set status to 'running' directly; "
"use the dispatcher/claim path"
),
)
results.append(entry)
continue
elif s in ("todo", "triage"):
ok = _set_status_direct(conn, tid, s)
else:
entry.update(ok=False, error=f"unknown status {s!r}")
Expand Down
25 changes: 25 additions & 0 deletions tests/plugins/test_kanban_dashboard_plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -710,6 +710,31 @@ def test_bulk_status_done_forwards_completion_summary(client):
conn.close()


def test_bulk_status_running_rejected(client):
"""Bulk updates must match single-task PATCH: direct 'running' is invalid."""
t = client.post("/api/plugins/kanban/tasks", json={"title": "x"}).json()["task"]

r = client.post(
"/api/plugins/kanban/tasks/bulk",
json={"ids": [t["id"]], "status": "running"},
)

assert r.status_code == 200
results = r.json()["results"]
assert len(results) == 1
assert results[0]["id"] == t["id"]
assert results[0]["ok"] is False
assert "running" in results[0]["error"]

board = client.get("/api/plugins/kanban/board").json()
statuses = {
tt["id"]: col["name"]
for col in board["columns"]
for tt in col["tasks"]
}
assert statuses.get(t["id"]) != "running"


def test_dashboard_done_actions_prompt_for_completion_summary():
repo_root = Path(__file__).resolve().parents[2]
bundle = (
Expand Down