fix(kanban): reject direct running transitions in dashboard bulk updates - #24050
Closed
kronexoi wants to merge 1 commit into
Closed
fix(kanban): reject direct running transitions in dashboard bulk updates#24050kronexoi wants to merge 1 commit into
kronexoi wants to merge 1 commit into
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align the dashboard bulk update endpoint with the single-task PATCH behavior by rejecting direct transitions to
running.The kanban lifecycle requires tasks to enter
runningonly through the dispatcher/claim path, which creates the run row and claim metadata atomically. Before this change,/tasks/bulkstill allowedstatus="running", which could strand tasks in a fake running state without proper run/claim bookkeeping.Changes
status="running"inPOST /api/plugins/kanban/tasks/bulkok=falsewith a clear errorWhy
Single-task dashboard PATCH already rejects direct
runningtransitions. Bulk updates had drifted from that invariant and could bypass the dispatcher lifecycle.Testing
Passed:
test_patch_status_running_rejectedtest_bulk_status_readytest_bulk_status_done_forwards_completion_summarytest_bulk_status_running_rejectedtest_bulk_archivetest_bulk_reassigntest_bulk_unassign_via_empty_stringtest_bulk_partial_failure_doesnt_abort_siblingstest_bulk_empty_ids_400