Skip to content

fix(kanban): treat archived dependencies as satisfied in ready transitions - #23976

Closed
Que0x wants to merge 1 commit into
NousResearch:mainfrom
Que0x:fix/kanban-archived-dependency-parity
Closed

fix(kanban): treat archived dependencies as satisfied in ready transitions#23976
Que0x wants to merge 1 commit into
NousResearch:mainfrom
Que0x:fix/kanban-archived-dependency-parity

Conversation

@Que0x

@Que0x Que0x commented May 11, 2026

Copy link
Copy Markdown
Contributor

Summary

This fixes an inconsistency in Kanban dependency handling where archived parent tasks were not treated as satisfied in every ready-transition path.

Hermes already treated done and archived parents as satisfied in some places, but a few lifecycle paths still checked for done only. That caused child tasks to be incorrectly kept in todo / blocked states or rejected by the dashboard when they should have been allowed to move to ready.

What changed

  • Added a shared dependency helper in hermes_cli/kanban_db.py so parent satisfaction uses one rule everywhere.
  • Updated link_tasks() to avoid demoting a ready child when the newly linked parent is already archived.
  • Updated unblock_task() so a blocked child with archived parents returns to ready instead of todo.
  • Updated the dashboard direct status path to allow status=ready when all parents are done or archived.

Why this is correct

The board already considers archived dependencies satisfied in other code paths such as ready recomputation and claim gating. This change aligns the remaining transitions with that existing invariant instead of introducing new behavior.

Tests

Passed targeted regressions:

  • tests/hermes_cli/test_kanban_db.py -k "archived or unblock or link_keeps_ready_child_when_parent_already_done"
  • tests/plugins/test_kanban_dashboard_plugin.py -k "drag_drop_move_todo_to_ready"

Added coverage for:

  • linking an archived parent to a ready child
  • unblocking a child whose parent is archived
  • dashboard drag-drop / PATCH to ready with an archived parent

@alt-glitch alt-glitch added type/bug Something isn't working comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have duplicate This issue or pull request already exists labels May 11, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Duplicate of #23967 — same fix for #23180 (archived parent tasks not treated as satisfied in kanban dependency resolution).

@Que0x

Que0x commented May 11, 2026

Copy link
Copy Markdown
Contributor Author

Already fixed + duplicate.

Closed.

@Que0x Que0x closed this May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/plugins Plugin system and bundled plugins duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants