fix(kanban): treat archived dependencies as satisfied in ready transitions - #23976
Closed
Que0x wants to merge 1 commit into
Closed
fix(kanban): treat archived dependencies as satisfied in ready transitions#23976Que0x wants to merge 1 commit into
Que0x wants to merge 1 commit into
Conversation
Collaborator
Contributor
Author
|
Already fixed + duplicate. Closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes an inconsistency in Kanban dependency handling where archived parent tasks were not treated as satisfied in every ready-transition path.
Hermes already treated
doneandarchivedparents as satisfied in some places, but a few lifecycle paths still checked fordoneonly. That caused child tasks to be incorrectly kept intodo/blockedstates or rejected by the dashboard when they should have been allowed to move toready.What changed
hermes_cli/kanban_db.pyso parent satisfaction uses one rule everywhere.link_tasks()to avoid demoting a ready child when the newly linked parent is already archived.unblock_task()so a blocked child with archived parents returns toreadyinstead oftodo.status=readywhen all parents aredoneorarchived.Why this is correct
The board already considers archived dependencies satisfied in other code paths such as ready recomputation and claim gating. This change aligns the remaining transitions with that existing invariant instead of introducing new behavior.
Tests
Passed targeted regressions:
tests/hermes_cli/test_kanban_db.py -k "archived or unblock or link_keeps_ready_child_when_parent_already_done"tests/plugins/test_kanban_dashboard_plugin.py -k "drag_drop_move_todo_to_ready"Added coverage for:
readywith an archived parent