fix(kanban): promote dependents when a parent is archived - #23967
Closed
Zyrixtrex wants to merge 1 commit into
Closed
fix(kanban): promote dependents when a parent is archived#23967Zyrixtrex wants to merge 1 commit into
Zyrixtrex wants to merge 1 commit into
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a Kanban lifecycle inconsistency where archiving a parent task did not immediately unblock dependent children.
recompute_ready()already treatsarchivedparents the same asdone, butarchive_task()was not triggering that promotion pass. As a result, children could remain stuck intodountil a later dispatcher tick.This PR updates
archive_task()to recompute ready tasks after a successful archive and adds a regression test covering the behavior.Related Issue
No linked issue; found via code inspection.
Type of Change
Changes Made
archive_task()to callrecompute_ready(conn)after a successful archive.How to Test
todo.ready.Test Results
pytest tests/hermes_cli/test_kanban_db.py -k "archive_task_triggers_recompute_ready_for_dependents or unlink_tasks_triggers_recompute_ready" -q2 passed