fix(browser): pass sandbox flags via AGENT_BROWSER_ARGS - #23517
Closed
LeonSGP43 wants to merge 1 commit into
Closed
Conversation
2 tasks
Collaborator
|
See note from original issue #23496 :
|
This was referenced May 11, 2026
Contributor
|
Automated hermes-sweeper review: this browser sandbox env-var fix is already implemented on main. Evidence:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the sandbox-bypass env handoff in
tools/browser_tool.pyso local browser launches pass Chromium flags through the env var thatagent-browseractually reads.Today Hermes detects when
--no-sandbox --disable-dev-shm-usageis needed, but writes those flags toAGENT_BROWSER_CHROME_FLAGS.agent-browserexpectsAGENT_BROWSER_ARGS, so the bypass never reaches Chrome and headless launches still fail on root/AppArmor-restricted hosts.Related Issue
Fixes #23496
Type of Change
Changes Made
AGENT_BROWSER_CHROME_FLAGStoAGENT_BROWSER_ARGSintools/browser_tool.pytests/tools/test_browser_homebrew_paths.pyfor both root and AppArmor-restricted launchesAGENT_BROWSER_CHROME_FLAGSenv var in the launch pathHow to Test
uv run --frozen pytest -q -o addopts='' tests/tools/test_browser_homebrew_paths.pyAGENT_BROWSER_ARGS=--no-sandbox --disable-dev-shm-usageChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
uv run --frozen pytest -q -o addopts='' tests/tools/test_browser_homebrew_paths.py->24 passeduv run --frozen ruff check tools/browser_tool.py tests/tools/test_browser_homebrew_paths.py-> passed