fix(browser): pass current agent-browser sandbox args - #20014
Closed
EmpireOperating wants to merge 2 commits into
Closed
fix(browser): pass current agent-browser sandbox args#20014EmpireOperating wants to merge 2 commits into
EmpireOperating wants to merge 2 commits into
Conversation
EmpireOperating
force-pushed
the
fix/browser-agent-browser-args
branch
from
May 5, 2026 03:12
43080cb to
03fc399
Compare
EmpireOperating
force-pushed
the
fix/browser-agent-browser-args
branch
from
May 8, 2026 14:20
c34f1d0 to
a0f2142
Compare
Contributor
Author
|
Rebased this branch onto current Local validation from the rebased head (
CI notes after the rebase:
|
This was referenced May 11, 2026
Contributor
|
Thanks for the focused diagnosis and regression coverage. Automated hermes-sweeper review found that the sandbox-bypass behavior targeted here is already implemented on current
The linked competing-PR discussion also identifies this as the same env-var fix. Closing as implemented on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AGENT_BROWSER_ARGS, which is what currentagent-browserversions readAGENT_BROWSER_CHROME_FLAGSas a backward-compatible fallback for older agent-browser buildsTest plan
.venv/bin/python -m pytest -q tests/tools/test_browser_homebrew_paths.py tests/tools/test_browser_cdp_override.py tests/tools/test_browser_hardening.pygit diff --checkContext
origin/mainalready injects--no-sandboxfor root/AppArmor cases, but it currently writes onlyAGENT_BROWSER_CHROME_FLAGS. Currentagent-browserusesAGENT_BROWSER_ARGS, so the injected flags can be silently ignored and local browser startup can fail before DevToolsActivePort is written.