fix(feishu): extract reply context from quote field in incoming messages (#22934) - #23079
Closed
Bartok9 wants to merge 1 commit into
Closed
fix(feishu): extract reply context from quote field in incoming messages (#22934)#23079Bartok9 wants to merge 1 commit into
Bartok9 wants to merge 1 commit into
Conversation
…ges (NousResearch#22934) When a user long-presses a message and selects 'Quote' in Feishu/Lark, the event carries a quote object with message_id and text. The adapter only read parent_id / upper_message_id / root_id, leaving reply_to_message_id and reply_to_text empty and potentially routing the session incorrectly. Fix adds quote object extraction as a fallback, matching the pattern already used by the Signal adapter. Also avoids a redundant _fetch_message_text round-trip when the quoted text is already present in the event payload.
alt-glitch
added
type/bug
Collaborator
Contributor
Author
|
Closing — duplicate of #22935 which was filed earlier. Reviewed both; the competing fix is correct. Leaving a review comment there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22934.
When a user long-presses a message and taps 'Quote' in Feishu/Lark, the event carries a
quoteobject withmessage_idandtext. The adapter only readparent_id/upper_message_id/root_id, leavingreply_to_message_idandreply_to_textempty.Fix adds
quoteobject extraction as a fallback — same pattern as the Signal adapter (signal.pyline 509). Also avoids a redundant_fetch_message_textAPI round-trip when the quoted text is already present in the event payload.155/155 feishu tests passing.