fix(feishu): handle quote field for quoted replies - #22969
Closed
KhanCold wants to merge 2 commits into
Closed
Conversation
Feishu adapter was ignoring the quote field when users reply with a native quote (selecting part of a previous message). This caused reply_to_message_id and reply_to_text to be empty, losing reply context. Now extracts quote.id / quote.message_id and quote.text from the Feishu message, using them as fallback when parent_id / upper_message_id are not present. Mirrors the Signal adapter pattern. Fixes NousResearch#22934
alt-glitch
added
type/bug
Rebased on latest main. Fixes NousResearch#22969
Collaborator
Contributor
|
Thanks for this fix! Note that there's a related issue not covered by this PR: The thread_id = getattr(message, "thread_id", None) or getattr(message, "root_id", None) or None
This explains why some users see Hermes open a new topic when they reply with a quote in P2P. Recommended additional fix: # Only use thread_id for session routing, NOT root_id
thread_id = getattr(message, "thread_id", None) or NoneSee also: #22935 (our PR that includes both fixes) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing as duplicate of #22935 which covers the same fix more comprehensively (including root_id misattribution fix). Thanks for the feedback — will follow #22935 going forward.